kfrancis / chargify-dot-net

MIT License
20 stars 49 forks source link

Price Points? #52

Closed MartyIce closed 2 years ago

MartyIce commented 6 years ago

Are Price Points updatable with the API? I searched code for "price_point_id" and "PricePoint", but didn't get any hits.

If not, are there any plans to add in near future?

Thanks!

kfrancis commented 6 years ago

Can add this for you if you need.

praveen-prakash commented 6 years ago

Yes Please do. :) I also have to implement the same in my app.

vgooz commented 6 years ago

When are you planing to add price points support? I need this feature too. Thanks.

kfrancis commented 6 years ago

Happy to take PRs here

asfmadx commented 4 years ago

Is this going to be implemented?

danduyser commented 2 years ago

Any chance @EdLichtman wants to tackle this one? :)

EdLichtman commented 2 years ago

Haven't worked in here in a while and I definitely don't have a dev environment set up or dev credentials.

I'd be interested in trying to help, but I'd like to take some time to figure out automated tests.

kfrancis commented 2 years ago

Sorry, I've been a bit busy lately. If you can't @EdLichtman, just let me know.

EdLichtman commented 2 years ago

Hiya Kori,

I'm going to see what I can do about it over the next few weeks. I would be interested in pair programming if you'd like, since I would like to more pleasantly fit your pre-existing patterns (sorry for the outlier designed code I had previously written)

EdLichtman commented 2 years ago

Honestly @kfrancis I don't think I'll get it done. Things have been packed. If in a week from now you still haven't gotten it done, I'll see about trying it out, but I won't start working on it unless I come back and tell you I'm doing it. I don't want to stop you from delivering value to the people who rely on your library.

kfrancis commented 2 years ago

Well, I remember now why I didn't add it immediately. Kind of annoying to implement, especially if I want to keep XML format alive in there as well. Working on it.

kfrancis commented 2 years ago

89

kfrancis commented 2 years ago

See release v1.4.0.

Now, not all methods are currently implemented. I've found that this set of endpoints is rather fickle between json and XML. I'm still working on getting more information from Chargify, at which time I'll release an update.