Using Generics for Metadata

kfrancis / chargify-dot-net

MIT License

20 stars 49 forks source link

Using Generics for Metadata #78

Closed EdLichtman closed 4 years ago

EdLichtman commented 5 years ago

I'm trying to use the SetMetaFor and GetMetaDataFor methods, and I'm getting a runtime error thrown. I'd like to use a where T: constraint to give me a compile-time error, but I'd also like to use the generic: ISubscription, ICustomer instead of Subscription/Customer.

Is there a business reason you did not want the generics to be useable or could I fix that?

EdLichtman commented 5 years ago

Also, I'd like to make "Page" auto-set to null if it's not populated and add documentation to explain that page is indexed at 1

EdLichtman commented 5 years ago

https://github.com/kfrancis/chargify-dot-net/pull/79

EdLichtman commented 5 years ago

@kfrancis the code for both MetaData and CancelAtEndOfBilling were not working for Json, so I've started on a new path of clean JSON Implementation. let me know what you think please