search

kfrlib / kfr

Fast, modern C++ DSP framework, FFT, Sample Rate Conversion, FIR/IIR/Biquad Filters (SSE, AVX, AVX-512, ARM NEON)
https://www.kfrlib.com
GNU General Public License v2.0
1.65k stars 253 forks source link

Use new lambda processor in vs2019 to fix compiler error in vec unali… #105

Closed xnorpx closed 3 years ago

xnorpx commented 3 years ago

…gned_read

Fix tests build with VS2019 with MSVC frontend (non-clang)

cmake .. -DENABLE_TESTS=ON -- Selecting Windows SDK version 10.0.17763.0 to target Windows 10.0.19041. -- Install prefix = -- C++ compiler: MSVC 19.27.29111.0 C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe -- CMAKE_SYSTEM_PROCESSOR=AMD64 -- X86 -- MSVC -- CPU_ARCH=avx2

Added experimental flag after feedback from team:

https://developercommunity.visualstudio.com/content/problem/1184178/cgitxnorpxkfrtestsunitsimdveccpp1451-fatal-error-c.html

samuelriddle commented 3 years ago

Hello Marcus,

Should /Zc:lambda flag be added to the library settings too to fix it for all users of kfr? Or maybe is it related to tests only?

xnorpx commented 3 years ago

@samuelriddle I think it is related to the test only, but I haven't written any code to test the actual code path. This was mostly just to get a clean build with tests for MSVC frontend.

dancazarin commented 3 years ago

Thank you. Merged.