kfrlib / kfr

Fast, modern C++ DSP framework, FFT, Sample Rate Conversion, FIR/IIR/Biquad Filters (SSE, AVX, AVX-512, ARM NEON)
https://www.kfrlib.com
GNU General Public License v2.0
1.62k stars 248 forks source link

using std::complex #206

Closed xkzl closed 6 months ago

xkzl commented 6 months ago

Hi @dancazarin

Is there any disadvantage to enable/disable -DKFR_STD_COMPLEX ? Why is there such custom types and what would be your recommendation ?

dancazarin commented 6 months ago

In versions before KFR5 there were differences in SIMD operations with std::complex and kfr::complex. Since KFR5 there are no more differences/disadvantages. Since KFR6 KFR_STD_COMPLEX and kfr::complex will be removed in favor of using std::complex everywhere.