Invalid values in is_sampled and is_qualified

kfuku52 / amalgkit

RNA-seq data amalgamation for a large-scale evolutionary transcriptomics

BSD 3-Clause "New" or "Revised" License

7 stars 1 forks source link

Invalid values in is_sampled and is_qualified #74

Closed kfuku52 closed 3 years ago

kfuku52 commented 3 years ago

integrate prefills 'yes' in is_sampled and is_qualified, but that is not a valid value, and therefore getfastq automatically excludes the sample from analysis. The valid values are either 'Yes' or 'No'. @Hego-CCTB Could you fix it? You might want to use strtobool to relax the allowed variation.

Hego-CCTB commented 3 years ago

Good catch! Will be fixed soon.

Hego-CCTB commented 3 years ago

I rewrote load_metadata() to use strtobool. Changed integrate too, just in case.

https://github.com/kfuku52/amalgkit/commit/e1428b8fd1ed1109528d6b07b90f9ae03d60feaf

kfuku52 commented 3 years ago

Thank you!