Issues with XML test cases

kg-construct / rml-core

RML-Core: Main features for RDF generation with RML

https://w3id.org/rml/core/spec

Creative Commons Attribution 4.0 International

12 stars 9 forks source link

Issues with XML test cases #104

Open chrdebru opened 7 months ago

chrdebru commented 7 months ago

[x] No test case for testing selecting values from attributes see #107
[ ] Should we have a test case for selecting elements based on conditions?
[ ] More test cases for language maps? E.g., ensuring no terms are generated when the language map does not yield terms..

DylanVanAssche commented 7 months ago

No test case for testing selecting values from attributes: +1, feel free to add it if you have one.
Should we have a test case for selecting elements based on conditions?: Tricky XPath is welcome I suppose? People do tricky stuff with it so we should check it?
More test cases for language maps? E.g., ensuring no terms are generated when the language map does not yield terms.: For now we have the basics, but there might be corner cases left open, so all help is welcome. This is mostly for the maintainers to figure out?

chrdebru commented 7 months ago

I agree. I can add a test case for the first if @pmaria and @andimou agree that selecting attributes must use valid XPath queries.

chrdebru commented 7 months ago

@DylanVanAssche : The first should be solved with #107.

dachafra commented 3 months ago

I agree with @chrdebru on both pending tasks.

I also have many use cases with very tricky XPath expressions, that currently are not supported by many engines.

My question is: do we need them now? If yes, who wants to create them? If not, I'll mark it as working-group @DylanVanAssche @chrdebru

pmaria commented 3 months ago

[ ] Should we have a test case for selecting elements based on conditions?

I also have many use cases with very tricky XPath expressions, that currently are not supported by many engines.

These would fit best in the io-registry IMHO.

DylanVanAssche commented 3 months ago

I agree with @pmaria Tricky XPath expressions need to be specified and tested in rml-io-registry. We need to collect them first to have a good idea of what is called 'tricky' as that's very vague currently.

dachafra commented 3 months ago

More test cases for language maps? E.g., ensuring no terms are generated when the language map does not yield terms..

and what about the second? Do we need it? @DylanVanAssche

DylanVanAssche commented 3 months ago

and what about the second? Do we need it?

Depends if the spec requires that if no language tag is generated for the triple while there's a language map, that we don't generate a triple --> basic reference algorithm + spec definition is needed.