Open chrdebru opened 5 months ago
I proposed a PR for the second issue.
I fixed the third issue in #37
Added a suggestion for the first issue in #38 , but in this stage I prefer not to replace existing test cases but rather create more if it's an alternative instead of a bugfix, hence the 0000b
made a suggestion for the 4th and 5th issue in #39
made a suggestion for the 6th issue in #40
made a suggestion for 7th issue in #41
added test case 0010 for last issue in #42
All looks good. There is just one problem with 0010
--> it fails the shape files.
rml:objectMap [
rml:functionExecution <#Execution> ;
rml:returnMap [
rml:constant fns:domainOutput
]
]
But:
Node=_:B2b96fcbd08ae031e639d8d104ab45f88
Path=(((<http://w3id.org/rml/template>|<http://w3id.org/rml/constant>)|<http://w3id.org/rml/reference>)|<http://w3id.org/rml/returnMap>)|<http://w3id.org/rml/functionExecution>
Message:
Exactly one rml:template, one rml:constant, one rml:reference,
one rml:returnMap, or one rml:functionExecution is required.
And this one has both a returnMap and rml:FunctionExecution.
rml:constant "name" ;
in 0002 not be changed torml:reference "name" ;
The test description states that it tests whether the "false reference" is caught, but the test uses a constant and I do not see what is wrong with this mapping. The spec does not specify that constant expression maps are not allowed for input value maps.id-lab:toUpperCaseURL
a good function for test case 0004? It is underspecified and it does not play nicely with the usual behavior of trying to generate an absolute IRI. I would have understood it the test data contained a IRI, but the test case now assumes that the values is put next tohttp://
http://VENUS
is not a valid absolute IRIhttp:\\
(lower case) when it is missing, but transformshttp://
intoHTTP://
when it is provided.rml:return
other than the nested function call. Maybe 0001?