kg-construct / rml-fnml

RML-FNML: Transformation functions within RML
https://w3id.org/rml/fnml/spec
Creative Commons Attribution 4.0 International
6 stars 2 forks source link

Issues with test cases #33

Open chrdebru opened 5 months ago

chrdebru commented 5 months ago
chrdebru commented 5 months ago

I proposed a PR for the second issue.

bjdmeest commented 5 months ago

I fixed the third issue in #37

bjdmeest commented 5 months ago

Added a suggestion for the first issue in #38 , but in this stage I prefer not to replace existing test cases but rather create more if it's an alternative instead of a bugfix, hence the 0000b

bjdmeest commented 5 months ago

made a suggestion for the 4th and 5th issue in #39

bjdmeest commented 5 months ago

made a suggestion for the 6th issue in #40

bjdmeest commented 5 months ago

made a suggestion for 7th issue in #41

bjdmeest commented 5 months ago

added test case 0010 for last issue in #42

chrdebru commented 5 months ago

All looks good. There is just one problem with 0010 --> it fails the shape files.

        rml:objectMap [
            rml:functionExecution <#Execution> ;
            rml:returnMap [
                rml:constant fns:domainOutput
            ]
        ]

But:

Node=_:B2b96fcbd08ae031e639d8d104ab45f88
  Path=(((<http://w3id.org/rml/template>|<http://w3id.org/rml/constant>)|<http://w3id.org/rml/reference>)|<http://w3id.org/rml/returnMap>)|<http://w3id.org/rml/functionExecution>
  Message: 
        Exactly one rml:template, one rml:constant, one rml:reference,
        one rml:returnMap, or one rml:functionExecution is required.

And this one has both a returnMap and rml:FunctionExecution.