search

kg-construct / rml-star

RML-star: RDF-star generation for RML
https://w3id.org/rml/star/spec
Creative Commons Attribution 4.0 International
4 stars 4 forks source link

Examples of the Syntax of RML-Star #10

Closed eiglesias34 closed 1 year ago

eiglesias34 commented 1 year ago

Hello,

I have noticed some things in the examples that I would like to bring to your attention. First, two examples use the rr:datatype xsd:float clause but the results don't reflect it; in other words, ^^xsd:float does not appear as part of the resulting triples. This can confuse those who only use the examples as a guide. Second, there is no example where rml:quotedTriplesMap is used as an objectMap. Finally, I noticed that prefix for subjectMap and objectMap has been changed from rr to rml. My issue was that there is no indication (at least from my understanding) in the text about this change. When I saw subjectMaps and objectMaps with rml prefix in the examples, I did not know if that was a mistake.

Sincerely, Enrique Iglesias

dachafra commented 1 year ago

Thanks @eiglesias34. @anaigmo if you prefer, you can open a specific issue for each problem provided here.

anaigmo commented 1 year ago

Thanks for the feedback @eiglesias34 ! The new release includes fixes to what you. mention, section 2.1 now highlights the prefix change, but if you think it could be said elsewhere just let me know :)