search

kg2k1b / DAT_SF_16

1 stars 0 forks source link

Issue for HW 3 #5

Open ntwieneke opened 9 years ago

ntwieneke commented 9 years ago

Looks very good, you may want to consider cleaning the data of 0 values that don't make sense (such as a BMI of 0).

You might also want to add more comments explaining what is being done at each step, but other wise well done!

@ghego @Breucopter

kg2k1b commented 9 years ago

Thanks for the feedback, @ntwieneke I thought about cleaning the data for values such as 0, but decided against it since i am not a subject matter expert on diabetes or any of the variables in the data. I dont't know if i can make a strong case for taking some rows out, when a zero value in that row may actually be useful to the bigger picture.

And yes, i can definitely do a better job of adding comments explaining what is being done at each step.

Thanks again.

On Wed, Aug 19, 2015 at 4:14 PM, ntwieneke notifications@github.com wrote:

Looks very good, you may want to consider cleaning the data of 0 values that don't make sense (such as a BMI of 0).

You might also want to add more comments explaining what is being done at each step, but other wise well done!

@ghego https://github.com/ghego @Breucopter https://github.com/Breucopter

— Reply to this email directly or view it on GitHub https://github.com/kg2k1b/DAT_SF_16/issues/5.