search

kgar / foundry-vtt-tidy-5e-sheets

D&D 5e sheet layouts for Foundry VTT, focused on a clean UI, user ergonomics, and extensibility.
https://kgar.github.io/foundry-vtt-tidy-5e-sheets/
MIT License
41 stars 14 forks source link

Style Maintenance - Prose Mirror Editors #51

Open kgar opened 10 months ago

kgar commented 10 months ago

Review the styles for prose mirror editors. Ideally, prose mirror editor styles should be consolidated into a single SCSS file that affects actors, items, and any other Tidy 5e content which leverages these editors. Any customizations atop that should either be located closer to where they are relevant or eliminated in favor of making the experience consistent wherever these editors may be found.

Some visual issues discovered:

image image image

When hovering, the font is visible: image When not hovering, it is basically white on white: image

kgar commented 10 months ago

https://discord.com/channels/732325252788387980/1116078321067892796/1175338919341072516

TyphonJS (Michael) [UTC-7] TRL provides pre-made editor components for ProseMirror with CSS variables to control styles of the menu and more w/ connection to a document / update mechanism. A general note is that the core ProseMirror editor implementation is borked on v11 w/ multiple editors open at the same time. https://github.com/foundryvtt/foundryvtt/issues/10139. With the next TRL release out shortly the PM editor component will close when another opens to at least not fall afoul of that core bug.