Enrichers overlap on defult settings

kgar / foundry-vtt-tidy-5e-sheets

D&D 5e sheet layouts for Foundry VTT, focused on a clean UI, user ergonomics, and extensibility.

https://kgar.github.io/foundry-vtt-tidy-5e-sheets/

MIT License

41 stars 14 forks source link

Enrichers overlap on defult settings #80

Closed imivoltz closed 9 months ago

imivoltz commented 11 months ago

While using the default font and settings provided, if enrichers are too close to each other on adjacent paragraphs they overlap. Maybe some kind of indentation could be added for a cleaner look.

Diary entries on player character sheets do this somewhat already, maybe try to emulate the style provided there:

Foundry version: Version 11 Build 315 Dnd5e version: 2.4.0 Tidy5e version: 0.1.11

kgar commented 11 months ago

Can you copy your text from those editors and paste them in a comment here on github? I'd like to use them while updating the styles.

imivoltz commented 11 months ago

Una ola de energía sagrada sobrecarga tu cuerpo y explota en un área de 15 pies a tu alrededor. Las criaturas atrapadas en la explosión deben superar una tirada de salvación de [[/save con dc=@attributes.spelldc]] o sufrir [[/damage formula=2d8 type=Radiant]] de daño radiante y quedar @UUID[Compendium.warcraft-compendium.reglas.JournalEntry.4BLwhynrXF9bMyso.JournalEntryPage.xyUEqUbDwBAWIAel]{Cegados} hasta el final de tu próximo turno si fallan la salvación, o la mitad de daño si tiene éxito.

kgar commented 11 months ago

Looking at the default sheet, it looks like overlap is also an issue there:

Increasing the line height of the paragraphs ultimately makes them slightly too spread apart:

(I had to change the compendium reference so I could visualize an enricher.)

This could take some more time to think through. I may not be able to fix it as quickly as the original issue.

imivoltz commented 11 months ago

Not a worry! Thanks for looking into this, i understand it might not be a high priority on the overall!

kgar commented 10 months ago

Looking back at this, and looking at how other web applications handle line height and fields like this, I may just increase the line height to a comfortable place that accounts for enricher height. It's the only appropriate thing to do, I think.

Either way, I have a way forward to resolve this issue and will follow up when I've got a proposed fix.

kgar commented 10 months ago

What are your thoughts on this line height?

kgar commented 9 months ago

The latest release is now here with the increased line heights: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/releases/tag/v0.2.6

Closing issue as resolved. If you have any additional issues, feel free to reopen this github issue.