Open kgarg3 opened 10 years ago
Why does the search view not show the search text box initially. It only comes up when you click on the search icon.
You might want to add this svQuery.setIconifiedByDefault(false);
if you anted the textbox to always be there. Try it and let me know if that works!
:+1: nice work. A few notes after checking out the code:
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
cc @nesquena
Feedback:
Its probably a stretch, but one could incorporate the SwipeView in this project. Usually what happens when one clicks on an image to view the details is that the Details activity launches and from here the users can swipe through the app to get to the full images of the other thumbnails.
Cool idea, I think this would be a really nice optional task I might add for the next class.
Also, the search view, with your example, was really simple to implement. So you could add that as a task, which is simpler than an edit text + button, unless you specifically wanted us to implement that for a reason. The search dialog is used in a lot of apps, so it would be a good learning exercise.
I like the edit text + button just to reinforce relative layout but I agree with you this is a great optional task to switch it for a SearchView. I will add that to the next version of this assignment. Thanks!
My app is a complete, please review. /cc @nesquena @timothy1ee
Questions:
Note: Didnt have time to implement the optional feature.