kgersen / Allegiance

Allegiance - RTS + FPS Space Combat game
http://www.freeallegiance.org/
MIT License
18 stars 26 forks source link

MinRank and MaxRank registry settings are not permanent #202

Closed kgersen closed 8 years ago

kgersen commented 8 years ago

You can set in registry the minimal and maximum rank. If the server starts the rank limitation works correctly, until some changes game settings via newgamescreen (see screenshot).

Imported from trac ticket #203, created by pkk on 08-03-2010 at 22:47, last modified: 02-06-2012 at 17:33

kgersen commented 8 years ago

Gameserver Admin forum: http://www.freeallegiance.org/forums/index.php?showtopic=37058

Trac comment by pkk on 08-03-2010 at 22:49

kgersen commented 8 years ago

r968

Trac comment by Xynth on 08-13-2010 at 17:45

kgersen commented 8 years ago

Need a server with limited rank settings on beta to test this.

Trac comment by pkk on 08-15-2010 at 14:30

kgersen commented 8 years ago

Did some testing today.

Server rejects registry defined settings, when there are no players on a team who can hold GC.

Joining NOAT does not rejects settings in first place, only if the player (who had GC) leaves the server (all teams empty) will set rank limitation to any (0-9999).

Trac comment by pkk on 03-22-2011 at 14:11

kgersen commented 8 years ago

There's an if block that resets the ranks to 'any' whenever nobody's left on a team to prevent servers from becoming unusable. Need to skip it if the game is a blue game. This'll prevent resets from happening even if the registry doesn't define rank limits, but r968 will prevent anyone from changing rank limits on these games so it should be all good.

There's a related display error there too. The if block doesn't tell any of its players that it's changing the settings, so anyone left on NOAT will see the wrong thing if they look at NewGameScreen. I cbf'd fixing it though, it's too inconsequential.

Trac comment by TurkeyXIII on 05-31-2011 at 16:55

kgersen commented 8 years ago

Will be tested with next build, until then it stays open.

PS: Sorry for delay. :(

Trac comment by pkk on 02-02-2012 at 13:28

kgersen commented 8 years ago

Fixed with [1049].

Trac comment by pkk on 02-06-2012 at 17:31