"Repair" Kill check

[kgersen]

In odd situations where a weapon has both a negative damage modifier and a negative damage, Alleg uses the "nanite" section of the code in shipigc.cpp. While this DOES damage the hull, it currently does not have a "kill check" and will thus allow for infinite negative health.

The attached patch file adds in the "kill check" from the damage section. It works, but I'm not sure if everything's perfect - I've not tested it on a server yet. It could probably be streamlined a little bit, as well.

Steps to reproduce (After applying patch) 1) Put the static_core.igc file in the beta artwork (May want to keep a backup of the old one) 2) Start beta 3) Go to Training Mission 5 4) Kill enemy.

What SHOULD happen: The damage will bypass the shields (As it is using the nanite thing - This is why I did this, so shield-ignoring weapons are possible) and go directly to the hull, destroying the target as normal.

What NOW happens: The damage will bypass the shields and go directly to the hull. The target will NOT be destroyed and will simply continue to take damage, having an extending red health bar, until "real" damage is taken.

Imported from trac ticket #212, created by Andon on 08-06-2010 at 05:23, last modified: 08-09-2010 at 03:03

[kgersen]

Steps to reproduce? Attach necessary files.

Trac comment by anonymous on 08-06-2010 at 05:24

[kgersen]

Just did another test, and it seems that there's quite a bit of "lag" when this is used. Not entirely sure what's causing it - more testing is required.

Trac comment by Andon on 08-06-2010 at 05:46

[kgersen]

Problems with this: -No reticule unless targeting friendlies -Bypasses friendly fire restrictions

Those need to be remedied as well.

Trac comment by Andon on 08-06-2010 at 05:54

[kgersen]

Going to go about this in a different way with the core changes for R7

Trac comment by Andon on 08-09-2010 at 03:03