kgersen / Allegiance

Allegiance - RTS + FPS Space Combat game
http://www.freeallegiance.org/
MIT License
18 stars 26 forks source link

Sticky Wing Assingments #88

Closed kgersen closed 8 years ago

kgersen commented 8 years ago

A feature request has been voiced that would remember your last wing assignment and to persist this assignment to future games.

Initial work has been accepted and commited in changeset 543 to this end.

Imported from trac ticket #91, created by kolie on 06-18-2010 at 11:05, last modified: 08-12-2010 at 05:58

kgersen commented 8 years ago

I have updated my patch based on feedback for moving the hook to set the wing assignment. I feel that I have found the appropriate place for doing so.

http://www.drgunz.net/stickywing2.patch

Trac comment by kolie on 06-18-2010 at 11:35

kgersen commented 8 years ago

r548

http://alleg.scarybugs.net/attachment/build/R6/24/R6_b24_r548.exe needs testing

Trac comment by Imago on 06-18-2010 at 18:44

kgersen commented 8 years ago

Essentially closed.

See r549: "there is an edge case where i've marked for review in fsmission.cpp - needs more testing - if you promote a leader in game it sets you to attack wing instead of your saved wing?"

Trac comment by fuzzylunkin1 on 06-20-2010 at 02:26

kgersen commented 8 years ago

r533 and previous take care of the TWO edge cases (setting leaders, team screen & team pane)

Trac comment by Imago on 06-20-2010 at 07:01

kgersen commented 8 years ago

[http://www.freeallegiance.org/forums/index.php?s=&showtopic=56647&view=findpost&p=508387 Koln said]:

I can't see other people's wing, just mine.

[http://www.freeallegiance.org/forums/index.php?s=&showtopic=56647&view=findpost&p=508394 Hellsyng said]:

Join a game after it has started. You can only see your own wing and people who join after you, just not people who were playing before you.

Wings do become visible after someone who's wing you cannot see changes. ex. changing from attack to command

Trac comment by fuzzylunkin1 on 06-30-2010 at 22:15

kgersen commented 8 years ago

This is what needs to be done: if the client hasn't been told who is on what wing, show attack (or command if they are team leader) as the default - this is how it works now - the reason this is an issue now is that the default is blank, so people can easily tell something is "up"

Trac comment by Imago on 06-30-2010 at 22:40

kgersen commented 8 years ago

I just now verified in current production release /w the help of Trombe the client default is Command, the clients don't know the wings of teammates when the join is into a running game, it shows everyone else on your team as command wing in F6.

Trac comment by Imago on 07-05-2010 at 03:30

kgersen commented 8 years ago

r652

Trac comment by Imago on 07-05-2010 at 06:03

kgersen commented 8 years ago

a fresh install lacks the reg gey and allows the user to get into the game w/o a wing appearing to others

Trac comment by Imago on 08-01-2010 at 18:47

kgersen commented 8 years ago

Ver 1.06.7781.55476

From a fresh install: Joining a team puts me on Command wing...as soon as I view "Game Settings" menu, I switch to Attack wing. duplicate ticket was #149

_Trac comment by Big_BetaTester on 08-11-2010 at 15:25

kgersen commented 8 years ago

If you join a team a empty team, you will be automatically Commander and on command-wing.

The registry key WingAssignment isn't changed to "0" (command) if you are made commander.

If you go to Game Settings screen and back, the registry key is loaded (which is currently "1" (attack) or something else).

Trac comment by pkk on 08-11-2010 at 17:13

kgersen commented 8 years ago

r962

Trac comment by Imago on 08-12-2010 at 05:58