kgislsompo / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

add testfw support for ConcurrentMap interface methods #149

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The test framework is thorough beyond belief for those interfaces that it
covers. Are there any plans for widening coverage to some of the more
specific collection framework interfaces? ConcurrentMap is the first that
springs to mind, NavigableMap, Deque, SortedSet and the like might be
useful too. Obviously, providing testing for the *concurrency* part of this
is a whole different ballgame, but it would be a great start to be able to
test at least the single-threaded behaviour.

More generally (perhaps this belongs in a separate issue), are there any
plans to make it easier to hook into the framework to test other types? As
a concrete example, I was playing with adding supplyIfAbsent(K,
Callable/Future<V>) to ConcurrentMap. To cleanly use the test framework
(after sorting out tests for the other four ConcurrentMap methods) it would
help to have some changes in, for example,
   * AbstractMapTester#getMap() to avoid the downcasts to my Map subtype
   * TestStringMapGenerator#create(Entry[]) for the same reason
   * MapTestSuiteBuilder#getTesters to make it easier to add testers to the
list, since Arrays#asList is inconveniently immutable.

Original issue reported on code.google.com by joe.kear...@gtempaccount.com on 14 Apr 2009 at 3:22

GoogleCodeExporter commented 9 years ago

Original comment by kevin...@gmail.com on 17 Sep 2009 at 5:57

GoogleCodeExporter commented 9 years ago

Original comment by kevin...@gmail.com on 17 Sep 2009 at 6:02

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 30 Jul 2010 at 3:53

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 26 Jan 2011 at 9:58

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 27 Jan 2011 at 1:47

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 13 Jul 2011 at 6:18

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 16 Jul 2011 at 8:37

GoogleCodeExporter commented 9 years ago
If I'm not mistaken, we should now have ConcurrentMapInterfaceTest out there 
and visible now.  Although, we quite embarrasingly discovered that we are not 
even using it (!!).  We would love to get a patch to convert it into a 
ConcurrentMapTestSuiteBuilder and make use of it for MapMaker and CacheBuilder 
testing.

Original comment by kevin...@gmail.com on 2 Sep 2011 at 1:58

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 10 Dec 2011 at 3:37

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 30 May 2012 at 7:51

GoogleCodeExporter commented 9 years ago
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:16

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:19

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:10