kgiszewski / Archetype

Archetype is an Umbraco 7 property editor that wraps other installed property editors.
https://github.com/kgiszewski/ArchetypeManual
MIT License
89 stars 54 forks source link

Fieldset Publishing Icon Appears Even When Fieldset Publishing is Disabled #382

Closed Nicholas-Westby closed 7 years ago

Nicholas-Westby commented 7 years ago

Not sure why I'm seeing this icon:

image-archetype

I have the "Enabled Fieldset Publishing" checkbox disabled for this Archetype. Here's the full config model:

{
  "showAdvancedOptions":false,
  "startWithAddButton":false,
  "hideFieldsetToolbar":false,
  "enableMultipleFieldsets":true,
  "hideFieldsetControls":false,
  "hidePropertyLabel":false,
  "maxFieldsets":1,
  "enableCollapsing":false,
  "enableCloning":false,
  "enableDisabling":false,
  "enableDeepDatatypeRequests":false,
  "fieldsets":[
    {
      "alias":"image",
      "remove":false,
      "collapse":false,
      "labelTemplate":"[Image] {{alternateText}}",
      "icon":"icon-picture",
      "label":"Image",
      "properties":[
        {
          "alias":"alternateText",
          "remove":false,
          "collapse":true,
          "label":"Alternate Text",
          "helpText":"",
          "dataTypeGuid":"5796f2e7-8aa7-4fbd-a2de-c7411c40d61c",
          "value":"",
          "aliasIsDirty":true,
          "required":true,
          "$$hashKey":"0YS"
        },
        {
          "alias":"image",
          "remove":false,
          "collapse":true,
          "label":"Image",
          "helpText":"",
          "dataTypeGuid":"c464e254-75e9-4b9e-99e7-490f39f3e90f",
          "value":"",
          "aliasIsDirty":true,
          "required":true,
          "$$hashKey":"0YT"
        },
        {
          "alias":"quality",
          "remove":false,
          "collapse":true,
          "label":"Quality",
          "helpText":"",
          "dataTypeGuid":"ac544868-831d-45d8-8d06-c8b5bd9c5ad5",
          "value":"",
          "aliasIsDirty":true,
          "required":true,
          "$$hashKey":"0YU"
        }
      ],
      "group":null,
      "aliasIsDirty":true,
      "$$hashKey":"0YJ"
    }
  ],
  "fieldsetGroups":[

  ],
  "selection":[

  ]
}

Here's a screenshot of the options screen:

global-fieldset-options

And now that I'm posing this report, I noticed the JSON doesn't actually contain a key for "enablePublishing". Once I checked and unchecked the "Enable Fieldset Publishing" checkbox, I then noticed an "enablePublishing" key set to a value of "false", and the icon has disappeared.

Maybe the problem is that this "enablePublishing" key isn't added to the default JSON when initially creating the Archetype? Here's my new JSON (note the new key at the bottom):

{
  "showAdvancedOptions":false,
  "startWithAddButton":false,
  "hideFieldsetToolbar":false,
  "enableMultipleFieldsets":true,
  "hideFieldsetControls":false,
  "hidePropertyLabel":false,
  "maxFieldsets":1,
  "enableCollapsing":false,
  "enableCloning":false,
  "enableDisabling":false,
  "enableDeepDatatypeRequests":false,
  "fieldsets":[
    {
      "alias":"image",
      "remove":false,
      "collapse":false,
      "labelTemplate":"[Image] {{alternateText}}",
      "icon":"icon-picture",
      "label":"Image",
      "properties":[
        {
          "alias":"alternateText",
          "remove":false,
          "collapse":true,
          "label":"Alternate Text",
          "helpText":"",
          "dataTypeGuid":"5796f2e7-8aa7-4fbd-a2de-c7411c40d61c",
          "value":"",
          "aliasIsDirty":true,
          "required":true,
          "$$hashKey":"25P"
        },
        {
          "alias":"image",
          "remove":false,
          "collapse":true,
          "label":"Image",
          "helpText":"",
          "dataTypeGuid":"c464e254-75e9-4b9e-99e7-490f39f3e90f",
          "value":"",
          "aliasIsDirty":true,
          "required":true,
          "$$hashKey":"25Q"
        },
        {
          "alias":"quality",
          "remove":false,
          "collapse":true,
          "label":"Quality",
          "helpText":"",
          "dataTypeGuid":"ac544868-831d-45d8-8d06-c8b5bd9c5ad5",
          "value":"",
          "aliasIsDirty":true,
          "required":true,
          "$$hashKey":"25R"
        }
      ],
      "group":null,
      "aliasIsDirty":true,
      "$$hashKey":"25G"
    }
  ],
  "fieldsetGroups":[

  ],
  "selection":[

  ],
  "enablePublishing":false
}

Alternate theory: maybe I copied this JSON from a prior installation before the fieldset publishing feature existed. Current Archetype version is 1.13.1, and Umbraco is 7.5.6.

kjac commented 7 years ago

@Nicholas-Westby I don't see the publishing icon unless I explicitly enable publishing in my config. Is this a recurring problem for you, or was it just a one-shot issue?

Nicholas-Westby commented 7 years ago

@kjac I'll close this. I think it was due to copying the JSON from an older version of Archetype that didn't have some of the new properties.