kgjamieson / NEXT-psych

Apache License 2.0
3 stars 2 forks source link

Random Sampling does not work from Dueling Bandits launch experiment interface #4

Closed flownandez closed 9 years ago

flownandez commented 9 years ago

Experiment design interface says "oops there is an error" if we try to use the "random sampling" algorithm instead of the default algorithm (Dueling Bandits).

stsievert commented 9 years ago

This is present when adding the uncertainty sampling too. I believe it's an issue with adding an algorithm.

stsievert commented 9 years ago

Closed. Added options for the algorithms in Info.py in the new_experiment_params.html lists the supported algorithms in DuelingBanditsPureExploration.

It looks like Random Sampling and Uncertainty Sampling are not implemented for Dueling Bandits. I removed those options, which doesn't feel kosher.

lalitkumarj commented 9 years ago

But does the edit functionality work? That's the key.

On Wed, Oct 28, 2015 at 7:49 PM, Scott S. notifications@github.com wrote:

Closed. Added options for the algorithms in Info.py https://github.com/kgjamieson/NEXT-psych/blob/master/next/apps/DuelingBanditsPureExploration/Info.py#L61 in the new_experiment_params.html lists the supported algorithms in DuelingBanditsPureExploration.

— Reply to this email directly or view it on GitHub https://github.com/kgjamieson/NEXT-psych/issues/4#issuecomment-152042720 .

stsievert commented 9 years ago

No, it doesn't work. I had thought you had added the functionality to edit a while ago?

lalitkumarj commented 9 years ago

Just on triplets...go look at how it is done. IT's the same mechanism across all of them.

On Wed, Oct 28, 2015 at 8:29 PM, Scott S. notifications@github.com wrote:

No, it doesn't work. I had thought you had added the functionality to edit a while ago?

— Reply to this email directly or view it on GitHub https://github.com/kgjamieson/NEXT-psych/issues/4#issuecomment-152047415 .

stsievert commented 9 years ago

I can do that tomorrow... I'll have to dig into a bit. I edited some of the triplet code and right now for editing a triplet experiment, I get the below: screen shot 2015-10-28 at 8 33 00 pm

lalitkumarj commented 9 years ago

No...something has clearly broken. I got this working.

On Wed, Oct 28, 2015 at 8:34 PM, Scott S. notifications@github.com wrote:

I can do that tomorrow... I'll have to dig into a bit. Right now for editing a triplet experiment, I get the below: [image: screen shot 2015-10-28 at 8 33 00 pm] https://cloud.githubusercontent.com/assets/1320475/10807922/47b30d80-7db3-11e5-9468-a7798316369f.png

— Reply to this email directly or view it on GitHub https://github.com/kgjamieson/NEXT-psych/issues/4#issuecomment-152047996 .

stsievert commented 9 years ago

I added the ability to edit DuelingBandits algorithms.

I also added a clarification when editing an experiment... if it's running, you can only edit the name/description.

screen shot 2015-10-29 at 10 11 39 am