disables "quote selected text" feature

alxndr commented 1 year ago

Expected behavior

Normally when a user is reading a post, and the "default other enable quoting" option is on (terrible name), they can select/highlight some text in a post, and then a popup appears next to / above the selection with a "Quote" button (and maybe other buttons too). If the user clicks this button, a new reply to the post is started (or existing draft is amended) containing [quote="..."]...[/quote] in the body.

Turning the plugin off will restore the "Quote" button popup behavior.

Note that these errors/warnings are not interfering with the correct behavior:

Screenshot of JS console with warnings and errors

Buggy behavior

With v0.2.2 (and maybe earlier), in Discourse v3.3.0.beta1:

after selecting text, the popup does not appear;
after selecting text, pressing q keyboard shortcut does not start the new reply at all, never mind with the quote;
after selecting text, clicking the "Reply" button starts a new reply but it does not include the selected text.

Working correctly

Entering the [quote] code manually in a reply to the topic is still working as expected.

The j / k keyboard shortcuts (navigating down/up in the thread and selecting a topic), and then pressing q, does work to create a new reply and quote the entire selected post.