search

kgmt0 / megapixels

The GTK camera application
GNU General Public License v3.0
20 stars 5 forks source link

upstreaming the PPP patches? #3

Open ollieparanoid opened 2 years ago

ollieparanoid commented 2 years ago

@kgmt0: thanks a lot for the great work you've done here with initial PinePhone Pro support, this is amazing!

Could you submit your patches against megapixels upstream here? https://gitlab.com/postmarketOS/megapixels/

There is also a matrix room if you want to chat about getting this into upstream: #megapixels:postmarketos.org

Code living upstream in one place makes collaboration easier, ideally leading to others jumping in on the PPP camera support.

kgmt0 commented 2 years ago

I would be happy to submit a PR/MR upstream, but there's an unmerged MR that my patches rely on. It looks like the MR is broken on regular PinePhones, which I unfortunately cannot help with since I only have a PinePhone Pro.

ollieparanoid commented 2 years ago

Ah understandable, thanks for explaining. I've commented on that MR as well, hopefully we can get that moving.

luigi311 commented 1 year ago

Looks like that MR was finally merged in and fixed so unless there are any other issues this should be able to be upstreamed now.

kgmt0 commented 1 year ago

@luigi311 Thanks for letting me know. Right now the code is broken on newer kernels (#4). I'll prepare an MR after I'm done fixing it.

luigi311 commented 1 year ago

Looks like the upstream has a ppp branch already not sure how well it works though.

kgmt0 commented 1 year ago

Looks like the upstream has a ppp branch already not sure how well it works though.

It just segfaults immediately for me.

sc0w commented 1 year ago

I have tested https://github.com/kgmt0/megapixels in mobian og pp, and it works fine

$ uname -a
Linux mobian 6.1-sunxi64 #1 SMP Mon Dec 12 17:39:56 UTC 2022 aarch64 GNU/Linux