kgns / weapons

CS:GO Custom Weapon Options (Skins, NameTag, StatTrak, Wear/Float, Knives)
GNU General Public License v3.0
335 stars 121 forks source link

Custom float #261

Closed samyycX closed 1 year ago

samyycX commented 1 year ago

Add an option in float menu to custom the float, i have tested it Still need translation for other languages.

crashzk commented 1 year ago

I believe that with this PR we can close issues https://github.com/kgns/weapons/issues/243 after it is merged.

crashzk commented 1 year ago

@samyycX any command to use custom float? Menu has no option.

20230211141908_1

samyycX commented 1 year ago

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

crashzk commented 1 year ago

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

Exactly, I found it there, but another problem appeared now.

When I type a flooat it only shows the error message: Invalid float (0-1).

samyycX commented 1 year ago

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

Exactly, I found it there, but another problem appeared now.

When I type a flooat it only shows the error message: Invalid float (0-1).

What did you input? try a format like 0.01

crashzk commented 1 year ago

umm theres should be an option in the float menu (the same page as the option to change the percentage), i didn't write a command to change it

Exactly, I found it there, but another problem appeared now. When I type a flooat it only shows the error message: Invalid float (0-1).

What did you input? try a format like 0.01

It worked, it has to be a number that starts with 0. the same, anything else gives an error.

I believe that now it would be interesting to just move it to the main menu and in addition to the option for the user to choose the float a menu to increase and decrease automatically, something like the wear and tear already has.

samyycX commented 1 year ago

umm im not a native English speaker so I’m not very sure whats the purpose to move it to the main menu and what does “increase float automatically” mean.. could you explain that?

crashzk commented 1 year ago

Main menu would be this what I wanted to say would be this: (Float option in this menu in case) 20230211151236_1

Then when the player clicks on the option Float from the menu inside it would be the options:

Something similar to the weapon wear menu. (Increase %5 and Decrease %5) 20230211151613_1

crashzk commented 1 year ago

@samyycX wait, I think I'm crazy, I'm confusing this Custom Float function... lol

I thought one thing and it's another... sorry.

Turned on the light here in the head, float is weapon wear too. Sorry again.

samyycX commented 1 year ago

@crashzk Can this PR be merged now? if we still need to improve it please tell me

crashzk commented 1 year ago

@crashzk Can this PR be merged now? if we still need to improve it please tell me

Unfortunately only @kgns can merge the PR, only he has access. But I made a fork for the version I use, I'm using it on my servers with your modification and it's working perfectly, without errors. For me it can be merged without problems. I'll be leaving a ping on @kgns and as soon as he gets attention he checks if everything is right and merges.

samyycX commented 1 year ago

@crashzk Can this PR be merged now? if we still need to improve it please tell me

Unfortunately only @kgns can merge the PR, only he has access. But I made a fork for the version I use, I'm using it on my servers with your modification and it's working perfectly, without errors. For me it can be merged without problems. I'll be leaving a ping on @kgns and as soon as he gets attention he checks if everything is right and merges.

got it, thank u very much