search

kgori / sigfit

Flexible Bayesian inference of mutational signatures
GNU General Public License v3.0
33 stars 8 forks source link

Rename Stan models for coherence #11

Closed baezortega closed 7 years ago

baezortega commented 7 years ago

Models should be renamed for coherence, using a convention like:

sigfit_emu.stan -> sigfit_ext_emu.stan sigfit_emu_fixed.stan -> sigfit_fit_emu.stan sigfit_fit.stan -> sigfit_fit_nmf.stan sigfit_hier.stan -> sigfit_fit_nmf_hier.stan sigfit_nmf.stan -> sigfit_ext_nmf.stan new fit+extract models: sigfit_fitex_nmf.stan; sigfit_fitex_emu.stan

Also, the parameter names should be consistent across models: "signatures" and "exposures".

baezortega commented 7 years ago

Implemented. The sigfit_fit_emu model still needs to be added to the fit_signatures() function, and the new fit+extract models need to be included.