kgori / sigfit

Flexible Bayesian inference of mutational signatures
GNU General Public License v3.0
33 stars 8 forks source link

Can't find vignette #50

Closed Dagsbio closed 4 years ago

Dagsbio commented 5 years ago

Hi,

As of today, I can't find the vignette neither via browseVignettes("sigfit") nor http://htmlpreview.github.io/?https://github.com/kgori/sigfit/blob/master/inst/doc/sigfit_vignette.html

baezortega commented 5 years ago

Hi David,

It seems that the HTML vignette disappeared from GitHub at some point. You can try building the vignette locally using tools::buildVignettes("sigfit"). If you are successful, then you should be able to open it using browseVignettes("sigfit").

This issue will be solved with the release of sigfit v2.0, which is planned for this Friday. However, there are some changes to the package functions in the new version, so you would need to install the new version (once it's out) before trying to follow the new vignette.

Best, Adrian

Dagsbio commented 5 years ago

Thanks, the workaround did not work, but I surely can wait till friday :)

David.

baezortega commented 5 years ago

Hi David,

Just out of curiosity, could you check if this works for you?

tools::buildVignettes("sigfit", find.package("sigfit"))

Thanks, Adrian

Edit: I think this only works if the vignette is already installed. I found a way of building it locally, which will be included in the README for v2.0

Dagsbio commented 5 years ago

Hi Adrian,

Yep, that didn't work either so the problem might be the one you are mentioning.

Let me know if I can try anything else to help.

Cheers,

David.

baezortega commented 5 years ago

Hi David,

The new version of the package is already out on GitHub: https://github.com/kgori/sigfit.

The installation command has changed; I would recommend you to uninstall the version you have before installing the new one. Because the new version of Stan depends on C++14 rather than C++11, you might run into some issues. Let me know how it works.

Best, Adrian

Dagsbio commented 4 years ago

Thank you! will try right now

Dagsbio commented 4 years ago

Yes, now working perfectly :)