search

kgraefe / pidgin-hide-chat-on-join

Hide group chats while auto-joining them.
GNU General Public License v2.0
9 stars 0 forks source link

Windows binary: Compatibility with older Pidgin versions #16

Closed kgraefe closed 3 years ago

kgraefe commented 5 years ago

Aleron Ives via E-Mail:

Greetings!

I had a question about your "hide chat on join" Pidgin plugin. Would you be willing to allow all Pidgin versions to use it? It's currently only usable on Pidgin 2.12.0 or higher, but I suspect it would also work on earlier versions.

To my knowledge, unlocking the plugin is a one-line change. In hide_chat.c, you can change line 60 from:

PURPLE_MINOR_VERSION,

to

1,

and then the plugin will be compatible with Pidgin 2.1 and above.

Thanks for reading!

Aleron Ives via E-Mail:

Hello again, and thanks for replying!

> PURPLE_MINOR_VERSION gets replaced on compile-time
> by whatever Pidgin version you build the plugin against.

Yes, which means any Pidgin version < 2.12 is blocked from running the plugin, since that's what you compiled against. I'm not actually running Pidgin 2.1; that's just the version Eion Robb suggested I ask you to target, as that's the minimum required version he sets in his plugins (by replacing PURPLE_MINOR_VERSION with 1 before compiling).

I'm using Pidgin 2.11 for two reasons:

1) Pidgin 2.12 broke the log manager by removing old protocols completely, so it's no longer possible to search logs made with old protocols, e.g. AIM, after you update. Obviously, you don't need to be able to connect with dead protocols, but being able to easily search old logs for information is still helpful.

2) I've been told either Pidgin 2.12 or 2.13 broke emoji theme support, which would make Discord much more difficult to use when the emoji sent by other people would always show up as squares. Emoji themes work fine on 2.11, so I can see them, as well as use my own emoji.

I'm willing to accept any extra security risks for the time being for the sake of functionality that's important to me, so I was just hoping you'd consider removing the Pidgin 2.12 requirement, as I have plenty of Discord channels enabled for automatic joining that would benefit from your plugin.

In any event, thank you for taking the time to read my request.
kgraefe commented 3 years ago

I'd need to test against older versions of Pidgin. This is a rabbit hole I am not willing to jump.

You can always compile against those versions yourself.