search

kgreenek / rules_pcl

Bazel rules for building PCL libraries (PointCloudLibrary)
Apache License 2.0
15 stars 15 forks source link

Aj fix flann #5

Closed 00arun00 closed 2 years ago

kgreenek commented 2 years ago

Bump

kgreenek commented 2 years ago

I'm going to close this for being stale. I went ahead and added flann support on master in a separate commit, and cut a new release. Please try the latest release and let me know if that works for you, or if you need any additional changes.

One difference I notice is that I did not compile flann with omp enabled. I believe different compilers (e.g. clang) require different flags for omp, so I didn't want to add flags that would only work with one compiler.

You can override the @flann in your own WORKSPACE using a different build file before invoking pcl_dependencies if that is a blocker, or if it's important to support, maybe there is a good way to pass the right flags. I didn't spend much time investigating that.

Thanks again for the PR! I'm sorry we didn't get to merge it, but it was still very helpful.