kgress / scaffold

A Java based Selenium WebDriver abstraction
MIT License
4 stars 7 forks source link

BasePage should be added as a file in Scaffold instead of implementing projects #27

Closed kgress closed 4 years ago

kgress commented 4 years ago

Bug

The scaffold archetype includes a BasePage file that includes an overridable function of isOnPage(). The intent of this is to provide a means of page verification when navigating from one page to another and also give the user the ability to add additional functionality of their own.

Instead, we should add the BasePage file to Scaffold. This will cut down another file from the implementing code bases but give users the freedom to still create their own BasePage and override + add functionality.

Moving forward, we should think about adding shared functionality that can be added in BasePage.

Expected

Users shouldn't have to create their own BasePage object. Instead, it should live in Scaffold and users can extend off of it if they so choose.