kgress / scaffold

A Java based Selenium WebDriver abstraction
MIT License
4 stars 7 forks source link

Update WebDriverNavigation to provide WebDriverWrapper navigation #4

Closed kgress closed 2 years ago

kgress commented 5 years ago

Summary

With separation of concerns in mind, we should move the navigate method from the WebDriverWrapper to the WebDriverNavigation method. Inherently, I think this makes the most sense as the WebDriverNavigation is supposed to be responsible only for anything navigation related.

    /**
     * Navigate to a specified URL
     *
     * @return as a {@link Navigation}
     */
    public Navigation navigate() {
        return this.driver.navigate();
    }

We should also think about moving anything else navigation related outside of the navigation method.

A/C

kgress commented 2 years ago

I don't think we should remove this from WebDriverWrapper and add it to WebDriverNavigation. WebDriverWrapper is meant to be a 1:1 with WebDriver. Leaving this as is for now and will revisit later if need be.