kgress / scaffold

A Java based Selenium WebDriver abstraction

MIT License

4 stars 7 forks source link

ScreenshotRemoteDriver cannot save screenshot because CapabilityType.TAKES_SCREENSHOT doesn't exist on DesiredCapabilitiesConfigurationProperties #53

Closed kgress closed 4 years ago

kgress commented 4 years ago

Bug

ScreenshotRemoteDriver is not able to take a screenshot because there is currently no way to set CapabilityType.TAKES_SCREENSHOT (takesScreenshot) with the DesiredCapabilitiesConfigurationProperties class.

When the check is performed, it always comes back null.

Expected

Users should be able to get screenshots from the remote driver with the CapabilityType.TAKES_SCREENSHOT capability.

kgress commented 4 years ago

I personally think we can remove the check for the desired capability TAKES_SCREENSHOT in this context. If a user wants to get the screenshot from the driver, they are going to be calling this method explicitly.

It would make sense, imo, if Scaffold was automatically providing a screen shot helper for failed testing. Since the current implementation doesn't have this, I think we're safe with removing the check.