search

kgress / scaffold

A Java based Selenium WebDriver abstraction
MIT License
4 stars 7 forks source link

add w3c compatibility for saucelabs #62

Closed ghost closed 4 years ago

ghost commented 4 years ago

PR for #64. add w3c compatibility for saucelabs

kgress commented 4 years ago

I am reviewing the sauce labs doc here and will then review the PR.

Have you tested this on your own implementation using the DEV snapshot for scaffold?

[edit] I just ran your branch against sauce in my personal implementation just fine ✔️

kgress commented 4 years ago

Outside of the review comments, do you have any concern on backwards compatibility with this merge? In my review of the sauce documentation, I didn't come across anything that indicated the update in sauce options would break anything for other scaffold users.

kgress commented 4 years ago

I have opened #64 as a ticket to tie to this PR

ghost commented 4 years ago

Have you tested this on your own implementation using the DEV snapshot for scaffold?

I tested this against master branch of scaffold with the changes I added, using mvn install, updating the POM of my current project to use the DEV build that maven output, then running a test using a safari configuration.

kgress commented 4 years ago

Accidentally clicked on revert after I merged your commit. Apologies. Working on getting it merged back in.

kgress commented 4 years ago

I got your commit merged back in to master to trigger the deploy. You should be seeing version 2.7.0 propagating to maven central repository within the next few hours.

Thank you for your contribution!