Currently, the AbstractWebElement class implements a Scaffold interface called BaseWebElement. Right now, this interface is supposed to be a clone of the WebElement, from Selenium, but uses our strongly typed elements. It also protects the codebase from any major changes to the Selenium API.
However, there are currently some features in the BaseWebElement that are missing from the WebElement interface. This ticket is to update this class and interface to accurately clone the WebElement. For example, the isSelected() method is not being used.
We should make the current public getWebElement() method private and either rename this method or the existing protected getWebElement method to give us a better idea on what is going on.
Also, keep in mind that we have an AbstractClickable class that is used by elements such as ButtonWebElement. We should still ensure that we're encapsulating actions for elements correctly.
A/C
Scaffold's BaseWebElement should have all of the same functionality from WebElement provided
Scaffold should still ensure proper encapsulation by providing methods like click() in the AbstractClickable class.
We should rename the getWebElement() methods to accurately reflect the actions they are performing and also change their access accordingly.
kgress
commented
2 years ago
Summary
Currently, the
AbstractWebElementclass implements a Scaffold interface calledBaseWebElement. Right now, this interface is supposed to be a clone of theWebElement, from Selenium, but uses our strongly typed elements. It also protects the codebase from any major changes to the Selenium API.However, there are currently some features in the
BaseWebElementthat are missing from theWebElementinterface. This ticket is to update this class and interface to accurately clone theWebElement. For example, the isSelected() method is not being used.We should make the current public
getWebElement()method private and either rename this method or the existing protectedgetWebElementmethod to give us a better idea on what is going on.Also, keep in mind that we have an
AbstractClickableclass that is used by elements such asButtonWebElement. We should still ensure that we're encapsulating actions for elements correctly.A/C
BaseWebElementshould have all of the same functionality fromWebElementprovidedclick()in theAbstractClickableclass.getWebElement()methods to accurately reflect the actions they are performing and also change their access accordingly.