kgretzky / evilginx2

Standalone man-in-the-middle attack framework used for phishing login credentials along with session cookies, allowing for the bypass of 2-factor authentication
BSD 3-Clause "New" or "Revised" License
10.94k stars 1.97k forks source link

New, Unrelated, Serious issue. #218

Closed thecityofhereafter closed 5 years ago

thecityofhereafter commented 5 years ago

Out of nowhere, a mostly working phishlet stopped letting me generate certificates for it after deleting the /root/.evilginx/crt folder.

: phishlets enable google [18:06:53] [inf] enabled phishlet 'google' [18:06:53] [inf] setting up certificates for phishlet 'google'... [18:06:53] [war] failed to load certificate files for phishlet 'google', domain 'google.com.verify.computer': open /root/.evilginx/crt/google.com.verify.computer/google.crt: no such file or directory [18:06:53] [inf] requesting SSL/TLS certificates from LetsEncrypt... [18:06:54] [err] [‘accounts’.google.com.verify.computer] acme: Error 400 - urn:acme:error:malformed - Error creating new authz :: Invalid character in DNS name [18:06:54] [!!!] failed to obtain certificates [18:06:54] [inf] disabled phishlet 'google'

`proxy_hosts:

thecityofhereafter commented 5 years ago

I'm still getting this with any google service phishlet using the domain accounts.google.com.verify.computer but everything with facebook or other phishlets using different subdomains with lets encrypt works fine? and all these phishlets didnt have this problem until a few days ago? (and I made no changes to them)? did lets encrypt block me from registering a cert for this subdomain or something?

ewhitman1 commented 5 years ago

@thecityofhereafter can you upload the whole phishlet so that we can deeply look into the matter?

thecityofhereafter commented 5 years ago

https://github.com/thecityofhereafter/google.yaml/blob/master/google.yaml

@ewhitman1 it doesn't matter what phishlet I use, even a completely stripped one, if i try to use accounts.google as a subdomain in the encryption cert lets encrypt throws the same error...?

kgretzky commented 5 years ago

The issue is that it tries to insert quotes into subdomain name:

‘accounts’.google.com.verify.computer

This never has happened to me. Do you know why this may be the case? Do you have a log with similar error when using some of the other phishlets, like linkedin?

thecityofhereafter commented 5 years ago

@kgretzky

Seriously? I thought that looked WRONG at first as well, but eventually I just assumed that you put those quotes in the text output on purpose to highlight the subdomain part...

Every single phishlet I use including your STOCK phishlets have the output show up with 'quotes'.mydomain.com, it happens on the stock linkedin phishlet, facebook, all of the stock phishlets show up with quotes in the ssh session & log/output...

I am happy to send any logs or info, is there a specific log that would be more helpful?

I don't know if the quotes in the log/output are actually the problem though!!! -- because I WAS able to get the facebook phishlet pretty much working correctly about 2 weeks ago, and it still showed those 'quotes' in the output when the facebook phishlet was working...

So you're thinking that lets encrypt is giving that error because of invalid characters in the domain name when attempting to register the certificate? if so, I can assure you that is NOT the issue, because I have registered hundreds of certificates for phishlets in my testing so far and every single time it still showed those quotes around the subdomain and still succeeded in getting the certificate. :)

Any other thoughts? Thanks!

kgretzky commented 5 years ago

Please do provide more logs of other phishlets doing the same.