search

kgryte / github-create-issue

Create an issue on a GitHub repository.
MIT License
18 stars 3 forks source link

Remove deprecated field in payload. #1

Closed argonlaser closed 7 years ago

argonlaser commented 7 years ago

Thanks for the awesome library. I am using it in one of my projects.

Github has deprecated the assignee field and gave assignees field instead. Please refer this for the API doc.

I would be happy to raise a PR for fixing this. Let me know your thoughts on this.

kgryte commented 7 years ago

@argonlaser Thanks for reporting the issue. And yes, I am open to a PR to fix this. :)

argonlaser commented 7 years ago

Thanks a lot for the reply @kgryte . I am working on it. Could it be 2.0.0 by removing the deprecated field or could it stay backward compatible? (i.e. either of assignee or assignees can be given).

kgryte commented 7 years ago

@argonlaser Let's go with the breaking change; i.e., remove support for assignee and replace with assignees. When the PR is merged, I will published the package as 2.0.0.

argonlaser commented 7 years ago

Addressed in PR https://github.com/kgryte/github-create-issue/pull/2 . Please review and merge.

kgryte commented 7 years ago

Closed via #2.

kgryte commented 7 years ago

@argonlaser New major published. Thanks again for all your work!

argonlaser commented 7 years ago

@kgryte : Thanks a lot for merging.