kgrzybek / modular-monolith-with-ddd

Full Modular Monolith application with Domain-Driven Design approach.
MIT License
11.09k stars 1.74k forks source link

Missing application layer in module architecture tests #177

Closed GregoireWulliamoz closed 3 years ago

GregoireWulliamoz commented 3 years ago

First of all, I want to thank you for this huge masterpiece of knowledge that you all are building.

If I am not wrong, there is an issue in the module architecture tests. In the list of assemblies, the infrastructure layer is referenced two times. To fix that the module interface should be referenced instead.

List<Assembly> administrationAssemblies = new List<Assembly> { typeof(AdministrationModule).Assembly, typeof(MeetingGroupLocation).Assembly, typeof(AdministrationContext).Assembly };

Should be

List<Assembly> administrationAssemblies = new List<Assembly> { typeof(IAdministrationModule).Assembly, typeof(MeetingGroupLocation).Assembly, typeof(AdministrationContext).Assembly };

kgrzybek commented 3 years ago

Hi @GregoireWulliamoz ,

You are right, it was incorrect :)

Thank you for that contribution!