search

kgrzybek / modular-monolith-with-ddd

Full Modular Monolith application with Domain-Driven Design approach.
MIT License
11.09k stars 1.74k forks source link

Wrong comparison operator #197

Open aalmuqahwi opened 3 years ago

aalmuqahwi commented 3 years ago

https://github.com/kgrzybek/modular-monolith-with-ddd/blob/54d209639e501301e879aa0d0a84c9ea49e4689e/src/Modules/Meetings/Domain/Meetings/Rules/MeetingAttendeesLimitMustBeGreaterThanGuestsLimitRule.cs#L1-L21

I believe the comparison operator used in the IsBroken method is wrong because the rule is checking that meeting attendees limit must be greater than guests limit.

kgrzybek commented 3 years ago

Thanks @aalmuqahwi , agreed