This pull request addresses a critical issue where the backend Docker image was failing to build correctly. The root cause was traced back to the recent update involving directory.build.props and related files, which were not being included in the Docker image(s).
Details
directory.build.props Missing directory.build.props and related files in build process of docker images
Removed old project BuildingBlocks/EventBus/CompanyName.MyMeetings.BuildingBlocks.EventBus.csproj was still referenced in the build project which was removed during the upgrade to .net 8
Issue with Package References: In the API project, the package references included the PrivateAsset="All" flag. This was preventing dotnet pack from copying necessary files, leading to the build issue.
DB Migrator Context Adjustment: The Docker build context for the DB Migrator was set to ./src/database. This limited its access to files located at the root of ./src during the Docker build. I've adjusted the context to resolve this issue.
Compatibility with ARM-based MacBooks: Added platform: linux/amd64 to the mymeetingsdb container. This change ensures compatibility with ARM-based MacBooks (M1/M2), aiding in broader development support.
Suggested Documentation Update
Given the compatibility enhancement for ARM processors, I recommend we include a link in the README to guide users on configuring Docker to run SQL Server on ARM architectures. This will be particularly helpful for those using newer MacBook models.
Conclusion
These changes should resolve the backend en dbmigrator Docker image build issues and improve our project's compatibility across different development environments. I welcome any further suggestions.
In order to prevent breaking the docker images I created this issue #298
Summary
This pull request addresses a critical issue where the backend Docker image was failing to build correctly. The root cause was traced back to the recent update involving
directory.build.propsand related files, which were not being included in the Docker image(s).Details
PrivateAsset="All"flag. This was preventingdotnet packfrom copying necessary files, leading to the build issue../src/database. This limited its access to files located at the root of./srcduring the Docker build. I've adjusted the context to resolve this issue.platform: linux/amd64to themymeetingsdbcontainer. This change ensures compatibility with ARM-based MacBooks (M1/M2), aiding in broader development support.Suggested Documentation Update
Given the compatibility enhancement for ARM processors, I recommend we include a link in the README to guide users on configuring Docker to run SQL Server on ARM architectures. This will be particularly helpful for those using newer MacBook models.
Conclusion
These changes should resolve the backend en dbmigrator Docker image build issues and improve our project's compatibility across different development environments. I welcome any further suggestions. In order to prevent breaking the docker images I created this issue #298