search

kgullikson88 / Telluric-Fitter

Telluric fitting made easy
http://telfit.readthedocs.org/en/latest/
MIT License
20 stars 17 forks source link

fix gfortran build issue #32

Closed shihyuntang closed 3 years ago

shihyuntang commented 3 years ago

@kgullikson88 @gully Two changes:

  1. change to use the url in issue-15 branch
  2. make a gfortran_mode function that will manually add -std=legacy to the makefile.common file for gfortran user with version later than 7.5.0

This should fix all the installation issue we see.

gully commented 3 years ago

I'd recommend squashing the commits when accepting the PR. The other open PR can be rebased on top of this one.

shihyuntang commented 3 years ago

Hi @gully , Thank you for the approval on the changes. One question: Is there a schedule on making the updated telfit pip installable again after the merge? It will be nice to know so that I can make the corresponding changes for theIGRINS RV. Thank you.

gully commented 3 years ago

After a merge, it should be straightforward to deploy a version to PyPI, though that's under Kevin's credential's I suspect.

shihyuntang commented 3 years ago

Hi @kgullikson88 ,

If there is any concern for you from pulling this request please let me know. Thank you.

gully commented 3 years ago

OK, I have merged this PR. I am inclined to Tag this as a release on GitHub, in preparation for a deploy to PyPI.org