search

kgullikson88 / Telluric-Fitter

Telluric fitting made easy
http://telfit.readthedocs.org/en/latest/
MIT License
20 stars 17 forks source link

Get the latest lblrtm/lnfl #39

Open shihyuntang opened 3 years ago

shihyuntang commented 3 years ago

Hi @gully and @kgullikson88 ,

I was trying to see if one can use the latest lblrtm/lnfl from ARE-RC's github instead of the current old? version that telfit download form a zenodo space. And... it turns out to be super easy! Just clone both the lblrtm/lnfl from ARE-RC's github (and follow their setup instruction) to your .Telfit dir, overwrite the one lblrtm/lnfl for sure, re-run python setup.py build/install. AND done!

BTW, this will also fix the error pop up when you try to use the latest ifort as fortran complier. (Which... using ifort seems to still be the only way to fix this issue #9)

Cheers!

kgullikson88 commented 3 years ago

Yeah, I think it makes sense to include the latest release from their github. The reason it used the zenodo link previously was just because lblrtm was not on github at the time TelFit was written.

shihyuntang commented 3 years ago

Great! But, i am not sure what will be the best way to implement the installation of pkg from other git repo. Also, this section of code in setup.py line 190--192 need to match the latest line list version (which is v3.8 now). I can make a PR of the setup.py i used to make the current lblrtm version install, but one will need to manually change the version number in the future.... which is not that user friendly... Not sure how to streamline these...