kgullikson88 / Telluric-Fitter

Telluric fitting made easy
http://telfit.readthedocs.org/en/latest/
MIT License
20 stars 17 forks source link

build is not download #51

Closed alexmyczko closed 10 months ago

alexmyczko commented 2 years ago

when trying the software release 1.4.0 and just trying it to build, it tries to access the internet, and fails to do so:

Downloading data from https://zenodo.org/record/1202479/files/aer_v_3.2.tar.gz and putting it in directory /var/www/debian/telfit/telfit-1.4.0/.pybuild/cpython3_3.10_telfit/.TelFit/
error: HTTPSConnectionPool(host='zenodo.org', port=443): Max retries exceeded with url: /record/1202479/files/aer_v_3.2.tar.gz (Caused by ProxyError('Cannot connect to proxy.', NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f9d477e78e0>: Failed to establish a new connection: [Errno 111] Connection refused')))

building software should be just building software. not download stuff from somewhere. this disqualifies for software to be packaged for linux distributions (at least for debian).

thanks for investigating.

ps: tried to install on three hosts, failure 2/3

gully commented 10 months ago

Hello @alexmyczko thank you for this feedback! Yes, the current installation process requires an internet connection to retrieve the Line-by-line-radiative-transfer files from this Zenodo repository: https://zenodo.org/records/1202479

After some investigating it does not appear possible to package that file with TelFit, since it is 182 MB, and we wish to keep the GitHub repository size as minimal as possible. Plus, if LBLRTM has updates in the future we may update the download to point to newer versions.

The TelFit installation process is a known friction point for many users. We have an open Issue soliciting open-source contributions, either in the form of Pull Requests, or additions to the documentation as a "common pitfalls" guide. I'm going to close this Issue and we welcome feedback there: https://github.com/kgullikson88/Telluric-Fitter/issues/36

Thanks again for your feedback 🙏 , and glad that you were able to get this working eventually!