search

kgyrtkirk / hive-dev-box

21 stars 14 forks source link

Downgrade jdk8 to 1.8.0_262-b19 to avoid timestamp issue #16

Closed wecharyu closed 9 months ago

wecharyu commented 9 months ago

@kgyrtkirk @zabetak Pls take a look, the lateset zulu8-jdk would cause timestamp issue in CI, so we downgrade it to the original jdk8 version. FYI: https://github.com/apache/hive/pull/5004#issuecomment-1897934743

zabetak commented 9 months ago

Is there a HIVE jira for the problem? If not please create one. Can you also please clarify if the problem is in JDK or in our code?

wecharyu commented 9 months ago

Hive jira: HIVE-28014

zabetak commented 9 months ago

@wecharyu According to https://issues.apache.org/jira/browse/HIVE-28014?focusedCommentId=17808601&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17808601. It seems that you pushed this change to production. Please clarify if that's the case so that we merge this PR as well.

wecharyu commented 9 months ago

It seems that you pushed this change to production. Please clarify if that's the case so that we merge this PR as well.

Yes, I have applied this patch on production as a hot fix. Pls help review it.

kgyrtkirk commented 9 months ago

I thinked I submitted my notes...whatever

zabetak commented 9 months ago

Ahh sorry @kgyrtkirk the page didn't refresh. I can revert if you want.

kgyrtkirk commented 9 months ago

no worries - it was my bad; github only shows pending on those messages :D didn't noticed it