search

kh90909 / OakTerm

Serial terminal for the Digistump Oak over the Particle Cloud
8 stars 2 forks source link

Sidebar variable click should update table #39

Closed emcniece closed 8 years ago

emcniece commented 8 years ago

Currently when a variable is clicked in the sidebar, it grabs the last known value from the device_vars object (which is updated every 10 seconds) and adds it to the terminal. Since the sidebar variables are drawn from the update_devices interval (which updates every 60 seconds) the variable table is often outdated compared to the device_vars object.

When a variable in the sidebar is clicked, the corresponding value in the table should be updated.

kh90909 commented 8 years ago

This is fixed in the colored-clickable-vars branch...we can port the change from there. On Apr 7, 2016 8:42 PM, "Eric McNiece" notifications@github.com wrote:

Currently when a variable is clicked in the sidebar, it grabs the last known value from the device_vars object (which is updated every 10 seconds) and adds it to the terminal. Since the sidebar variables are drawn from the update_devices interval (which updates every 60 seconds) the variable table is often outdated compared to the device_vars object.

When a variable in the sidebar is clicked, the corresponding value in the table should be updated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/kh90909/OakTerm/issues/39

kh90909 commented 8 years ago

Wait, actually, it's not. It does query the variable, but the problem is that the query is asynchronous through a promise, so the value is not updated in time. We need to find a way to block or defer until the query returns. On Apr 7, 2016 9:20 PM, "Ken Healy" healykb@gmail.com wrote:

This is fixed in the colored-clickable-vars branch...we can port the change from there. On Apr 7, 2016 8:42 PM, "Eric McNiece" notifications@github.com wrote:

Currently when a variable is clicked in the sidebar, it grabs the last known value from the device_vars object (which is updated every 10 seconds) and adds it to the terminal. Since the sidebar variables are drawn from the update_devices interval (which updates every 60 seconds) the variable table is often outdated compared to the device_vars object.

When a variable in the sidebar is clicked, the corresponding value in the table should be updated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/kh90909/OakTerm/issues/39

kh90909 commented 8 years ago

In progress.