search

kh90909 / OakTerm

Serial terminal for the Digistump Oak over the Particle Cloud
8 stars 2 forks source link

Implement sending of events #46

Closed kh90909 closed 8 years ago

kh90909 commented 8 years ago

Clicking the send event button will bring up a modal where the user can enter the event name, data and private/public flag. The event is then sent via ParticleJS and success/failure dumped to the terminal.

Had to change the tooltip data-trigger attribute on the send event button from the default of 'hover focus' to just 'hover'. Otherwise, the tooltip would stay open until the modal was dismissed. Not sure what impact this will have on mobile, may need to find a different workaround.

The private/public checkbox is not aligning with it's label or the tooltip question mark icon. Needs fixing.

emcniece commented 8 years ago

Looks great! I haven't tested this on mobile yet, but the Private checkbox might be a bit small for a finger to hit. If this ends up being the case, we could consider using a toggle instead... it takes a bit more work to integrate (on/off states, text binding, etc) but might be easier on the fingers.

kh90909 commented 8 years ago

I can't test on mobile right now as rawgit is down and I'm not at home, but when I tested this on the desktop in Chrome, clicking on the "Private" label also toggled the checkbox.

Happy to go with a toggle though if that's more user friendly. On Apr 12, 2016 2:10 PM, "Eric McNiece" notifications@github.com wrote:

Looks great! I haven't tested this on mobile yet, but the Private checkbox might be a bit small for a finger to hit. If this ends up being the case, we could consider using a toggle http://v4-alpha.getbootstrap.com/components/buttons/#toggle-states instead... it takes a bit more work to integrate (on/off states, text binding, etc) but might be easier on the fingers.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/kh90909/OakTerm/pull/46#issuecomment-209037297

kh90909 commented 8 years ago

FYI, I tested on Android Chrome this evening and found that it does also toggle the checkbox in response to tapping on its label.

kh90909 commented 8 years ago

New commit replaces the checkbox with a Bootstrap radio button style toggle for a better mobile experience. Felt it was better to explicitly have "Private" and "Public" buttons, rather than just a "Private" button that toggles on and off.

emcniece commented 8 years ago

Toggles look great! I agree that this might be a bit more obvious, and it will be a bit easier on the thumbs.

kh90909 commented 8 years ago

Closes #32.