kh90909 / OakTerm

Serial terminal for the Digistump Oak over the Particle Cloud

8 stars 2 forks source link

Add note on login page explaining that no login information is saved on our servers #58

Closed kh90909 closed 8 years ago

kh90909 commented 8 years ago

e.g.

"No login information is stored on digistump servers. Your access token for the Particle Cloud is stored locally in your browser only, so that you don't have to log in each time you reload the page".

Optionally, add a "Remember me" checkbox that controls whether the access token is saved to localStorage. Otherwise, tell the user that the logout button will clear the saved token.

emcniece commented 8 years ago

Should the "Remember me" checkbox from the login page be stored in the settings object? Probably - and if so, should it also be represented in the settings modal?

kh90909 commented 8 years ago

I don't recall having ever seen a "remember me" setting within a web app (in a settings section after logging in, that is). Have you? I think storing it in the settings object would be fine, but I don't think it's a big deal if we default it to unchecked either.

emcniece commented 8 years ago

in progress.

emcniece commented 8 years ago

Now that we have a setting field outside of the #settings form, we can't simply serializeArray and save. This moves us toward a pattern where adding an HTML attribute of setting on a tag will qualify an input as a setting, and then we can parse $('[setting]').each() for all available setting states.

69 is a start for a patter adjustment - the next step is to clear credentials on logout or session end, and this would benefit from some of the methods established in #62.