search

kh90909 / OakTerm

Serial terminal for the Digistump Oak over the Particle Cloud
8 stars 2 forks source link

Change background colour of variable tags (or text colour) #84

Closed pfeerick closed 8 years ago

pfeerick commented 8 years ago

Can you change either the background colour or the text colour of the variable tags to a better contrast? On my Chrome/Linux setup it is coming up as a white tag with grey text for the name, so virtually unreadable!

image

kh90909 commented 8 years ago

Oh, that's not good. It looks like there was a bug in the css where it was expecting to see a variable type of 'int', when in fact the Particle Cloud returns the 'int32'. I fixed this in commit d73c55ecd628a331e472ff4fb9ceff251cbda494 and also darkened the intended yellow color because the contrast was still poor against the text. Try it out (refreshing the page should get you the latest version), and let me know how it looks.

In future, we should probably change the red double or green string colors, for the benefit of those who are red-green colorblind, but for now we do have tooltips indicating the variable type when you hover over the buttons.

pfeerick commented 8 years ago

Yup, that fixed it! :) Good contrasting colours too thanks! Now I just have to convince my Oak to actually register variables... but that is another non-OakTerm related issue!