kha7iq / pingme

PingMe is a CLI which provides the ability to send messages or alerts to multiple messaging platforms & email.

https://pingme.lmno.pk

MIT License

771 stars 43 forks source link

TextMagic support #57

Closed charconstpointer closed 3 years ago

charconstpointer commented 3 years ago

Description

Added support for TextMagic service

Fixes # (issue) https://github.com/kha7iq/pingme/issues/44

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[x] Running existing tests
[ ] Created new tests

Checklist:

[x] My code has been linted (make lint)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have rebased my branch to include the latest changes from master

kha7iq commented 3 years ago

Thank you @charconstpointer for making this contribution. Everything is good , just a few minor thing if you can fix this is good to merge after that.

Can you please create another branch in your fork and open a new PR from that instead of master. i.e

git checkout -b add-support-for-textmagic
git push --set-upstream origin add-support-for-textmagic

Can you please fix the typos and env variables in updated docs.