kha7iq / pingme

PingMe is a CLI which provides the ability to send messages or alerts to multiple messaging platforms & email.
https://pingme.lmno.pk
MIT License
771 stars 43 forks source link

pushover: possibility to use priority argument #72

Closed vmpr closed 12 months ago

vmpr commented 1 year ago

Hi and thanks for your great tool! I would like to be able to use the priority argument with your pingme tool for pushover, the go wrapper you are using ( https://github.com/gregdel/pushover ) has it already built in, so it should be not a significant effort to implement it into your code, but I can't program go so its hard for me to implement it myself :( thank you and have a great day! cheers Ringo

kha7iq commented 1 year ago

Hello @vmpr I saw its is available in the wrapper i am using, allow me some time to look into the implementation

kha7iq commented 1 year ago

Hello @vmpr I have added the priority flag for pushover, can you build from priority-for-pushover branch and test it.

  1. clone the repo & branch
    git clone -b priority-for-pushover https://github.com/kha7iq/pingme.git
  2. cd into the folder
  3. build the binary
    go build -o pingme main.go
  4. Send a message
    ./pingme pushover --token abc --msg "Priority value 1 " --title "Notify" -u xxxxxxx  -p 1

Let me know if this works for you , i will merge it after to main after that.

vmpr commented 12 months ago

Hello @kha7iq

I've tested it and it works like a charm! thank you!

cheers Ringo

kha7iq commented 12 months ago

Thank you for testing. Changes merged https://github.com/kha7iq/pingme/pull/74 Available in release 0.2.6