search

khabbazian / l1ou

Detection of evolutionary shifts in Ornstein-Uhlenbeck models
GNU General Public License v2.0
19 stars 7 forks source link

Pull the latest changes from l1ou #14

Closed yuqing19118 closed 8 years ago

cecileane commented 8 years ago

Sabrina: as mentioned before, changes to the manual should not be done in the man/ pages directly. They should be done in the commenting section just before a function. Also, you should use variable names that help understanding. For instance, I don't find C.IH to be very helpful to understand what this variable contains. A better name (longer, yes) would be something like "covInverseSqrt". Same thing about C.H.

Also, I don't see the point of the second set of examples, lines 77-89, for the purpose of the manual.

yuqing19118 commented 8 years ago

I have made the changes in estimate_shift_configuration function and also `sqrt_OU' function

khabbazian commented 8 years ago

Did I merge all the changes? At some point I got confused and it seems like I might not done that correctly.

Could you please check that?

From: qing yu notifications@github.com Sent: Thursday, October 27, 2016 9:56:45 PM To: khabbazian/l1ou Subject: Re: [khabbazian/l1ou] Pull the latest changes from l1ou (#14)

I have made the changes in estimate_shift_configuration function and also `sqrt_OU' function

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/khabbazian/l1ou/pull/14#issuecomment-256817637, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH3bi8HKH_-2MJSYMMipT2Aie-PF6a2hks5q4VZdgaJpZM4Kh5xf.