search

khabbazian / l1ou

Detection of evolutionary shifts in Ornstein-Uhlenbeck models
GNU General Public License v2.0
19 stars 7 forks source link

Updated is.binary.tree to is.binary #47

Closed Keffy closed 3 years ago

Keffy commented 3 years ago

Running estimate_shift_configuration() threw warnings due to ape deprecating is.binary.tree() in favor of is.binary()

The warning from the ape package:

is.binary.tree() is deprecated; using is.binary() instead.

is.binary.tree() will be removed soon: see ?is.binary and update your code.

cecileane commented 3 years ago

Thank you! Could you also please find out which minimum version of ape the package now requires (lower bound)? Then we can indicate this in the DESCRIPTION file.

Keffy commented 3 years ago

The lower bound for ape would now be ape 4.0 from November 2016.

http://ape-package.ird.fr/is_binary_tree.html

cecileane commented 3 years ago

Thanks! Could you please modify line 21 of the DESCRIPTION file to read like this?

ape (>= 4.0),

I don't have permission to add a commit to your fork, or push access to this repo, so I can't do the change myself. And then could you please take a look @khabbazian?

khabbazian commented 3 years ago

Thanks Cecile and Keffy.