Closed khaeru closed 10 months ago
Merging #147 (e5c358a) into main (c28f50a) will decrease coverage by
2.41%
. The diff coverage is100.00%
.
@miccoli, please let me know if you are able to test the fix on this branch. No problem if not; then I'll just merge and release.
@miccoli, please let me know if you are able to test the fix on this branch. No problem if not; then I'll just merge and release.
Yes I can test this branch. I have no access to my testing machine right now, but should be able to do it evening (CET).
:+1:
My workflows are OK running sdmx
from this branch. Thanks!
135 updated this line:
https://github.com/khaeru/sdmx/blob/c28f50af506db86da6a35b7df13d8739362eb0df/sdmx/reader/xml/v21.py#L683 …to refer to BaseDataStructureDefinition, the base class for {v21,v30}.DataStructureDefinition.
However,
Reader.get_single()
does not match on subclasses unlesssubclass=True
is given explicitly. The method would thus always return None, resulting in a warning, also perhaps other failures to use the provided DSD wherever code refers to thess_without_dsd
variable.This PR corrects, closing #146.
PR checklist