search

khaeru / sdmx

SDMX information model and client in Python
https://sdmx1.readthedocs.io
Apache License 2.0
23 stars 17 forks source link

Fix read/write of common.Contact #159

Closed khaeru closed 5 months ago

khaeru commented 5 months ago

PR checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f0e00bc) 98.72% compared to head (c425a6e) 96.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #159 +/- ## ========================================== - Coverage 98.72% 96.51% -2.21% ========================================== Files 87 87 Lines 7043 7055 +12 ========================================== - Hits 6953 6809 -144 - Misses 90 246 +156 ``` | [Files](https://app.codecov.io/gh/khaeru/sdmx/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto) | Coverage Δ | | |---|---|---| | [sdmx/reader/xml/v21.py](https://app.codecov.io/gh/khaeru/sdmx/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC9yZWFkZXIveG1sL3YyMS5weQ==) | `98.83% <100.00%> (-0.21%)` | :arrow_down: | | [sdmx/tests/reader/test\_reader\_xml\_v21.py](https://app.codecov.io/gh/khaeru/sdmx/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC90ZXN0cy9yZWFkZXIvdGVzdF9yZWFkZXJfeG1sX3YyMS5weQ==) | `100.00% <100.00%> (ø)` | | | [sdmx/tests/writer/test\_writer\_xml.py](https://app.codecov.io/gh/khaeru/sdmx/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC90ZXN0cy93cml0ZXIvdGVzdF93cml0ZXJfeG1sLnB5) | `100.00% <ø> (ø)` | | | [sdmx/writer/xml.py](https://app.codecov.io/gh/khaeru/sdmx/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto#diff-c2RteC93cml0ZXIveG1sLnB5) | `97.68% <ø> (ø)` | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/khaeru/sdmx/pull/159/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Natsuo+Kishimoto)