Closed FedorYatsenko closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
69aa84a
) 98.50% compared to head (ebe2953
) 96.45%.
Hi @FedorYatsenko —thanks for this contribution, much appreciated!
A couple of questions:
These would help me confirm the code works, and guide you in adding tests. Thanks in advance.
Hi @khaeru,
I'm afraid, I can't yet share a link to SDMX web services that will give responses to such queries. As @sychsergiy mentioned in the khaeru/sdmx#164, our data provider is hidden by a private network.
Consequently, I'm not sure if this help you, but here is the code we are using:
keys_dict = {
'INDICATOR': ['PCPIHA_IX', 'PCPIHA_PC_CP_A_PT', 'PCPI_PC_CP_A_PT'],
'COUNTRY': ['111', '134'],
'FREQUENCY': []
}
resp2 = sdmx_client.availableconstraint(
'CPI',
key=keys_dict,
dsd=cpi_dsd
)
It generates the following link: .../availableconstraint/CPI/111+134.PCPIHA_IX+PCPIHA_PC_CP_A_PT+PCPI_PC_CP_A_PT.*
.
And the following XML response: khaeru/sdmx-test-data#1
I am going to push a test for this file in this branch. Please let me know if I should change something.
Thanks for adding the specimen in the other repo. On the next push the tests on this branch should find it.
I need to at some point add a PR template with a check-list for contributors. For now, while you're working on this draft, could you please:
main
, resolving any conflicts (don't need to do this repeatedly, only when ready to review/merge).I'll come back to review when you indicate I should.
Thank you for merging the specimen.
As for the whatsnew and updates to the latest main, I'll do that soon.
Thank you very much for approving these changes.
By the way: I see on the commit 31a7ba12b1f3f32df02d64cdbe4dba04e8c64687 that the associated username is "Fedir_Yatsenko", whereas your GitHub username appears to be "FedorYatsenko". I don't know why there is a mismatch (maybe difference between your local configuration and GitHub account), but as a result GitHub does not correctly associate the commit with your account, and you don't show up yet in the list of contributors: https://github.com/khaeru/sdmx/graphs/contributors 🥲
I'm sorry for not noticing this earlier. I'll add a :thanks:
to doc/whatsnew.rst when I prepare the next release.
No worries. I just misspelled my name a little when creating my GitHub account.
Add support for data availability queries (availableconstraint) defined by the SDMX 2.1 standard